feat: package vllm runtime into image #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pack vllm runtime and chat_template files - align the requirements of the two runtimes - support to load chat_template for hf runtime Signed-off-by: jerryzhuang <[email protected]>
zhuangqh
requested review from
Fei-Guo,
helayoty and
ishaansehgal99
as code owners
Signed-off-by: jerryzhuang <[email protected]>
Signed-off-by: jerryzhuang <[email protected]>
Signed-off-by: jerryzhuang <[email protected]>
Signed-off-by: jerryzhuang <[email protected]>
Fei-Guo
approved these changes
Oct 29, 2024
Signed-off-by: jerryzhuang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #655 +/- ##
==========================================
- Coverage 58.18% 52.09% -6.10%
==========================================
Files 30 35 +5
Lines 2987 4279 +1292
==========================================
+ Hits 1738 2229 +491
- Misses 1149 1930 +781
- Partials 100 120 +20 ☔ View full report in Codecov by Sentry. |
ishaansehgal99
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Requirements
Issue Fixed:
Notes for Reviewers: